Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 5707009: Fix ChromeFrame test failures caused by the change to support about:plugins i... (Closed)

Created:
10 years ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix ChromeFrame test failures caused by the change to support about:plugins in full tab mode. BUG=66118 TBR=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome_frame/test/chrome_frame_automation_mock.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years ago (2010-12-14 05:16:22 UTC) #1
amit
10 years ago (2010-12-14 10:00:13 UTC) #2
lgtm

On Mon, Dec 13, 2010 at 9:16 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix ChromeFrame test failures caused by the change to support about:plugins
> in
> full tab
> mode.
>
> BUG=66118
> TBR=none
>
>
> Please review this at http://codereview.chromium.org/5707009/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/chrome_frame_automation_mock.h
>
>
> Index: chrome_frame/test/chrome_frame_automation_mock.h
> ===================================================================
> --- chrome_frame/test/chrome_frame_automation_mock.h    (revision 69077)
> +++ chrome_frame/test/chrome_frame_automation_mock.h    (working copy)
> @@ -11,6 +11,7 @@
>  #include "base/utf_string_conversions.h"
>  #include "chrome_frame/chrome_frame_automation.h"
>  #include "chrome_frame/chrome_frame_plugin.h"
> +#include "chrome_frame/navigation_constraints.h"
>  #include "chrome_frame/test/http_server.h"
>  #include "chrome_frame/test/chrome_frame_test_utils.h"
>  #include "chrome_frame/test/test_with_web_server.h"
> @@ -58,10 +59,10 @@
>
>   // Navigate external tab to the specified url through automation
>   bool Navigate(const std::string& url) {
> +    NavigationConstraintsImpl navigation_constraints;
>     url_ = GURL(url);
> -    bool result = automation_client_->InitiateNavigation(url,
> -                                                         std::string(),
> -                                                         false);
> +    bool result = automation_client_->InitiateNavigation(
> +        url, std::string(), &navigation_constraints);
>     if (!result)
>       OnLoadFailed(0, url);
>     return result;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698