Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 57065: Fix list of packages to install in install-build-deps.sh. (Closed)

Created:
11 years, 8 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Markus (顧孟勤)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix list of packages to install in install-build-deps.sh. BUG=9507 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13061

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Missed a variable in r11336.
11 years, 8 months ago (2009-03-31 18:14:00 UTC) #1
Markus (顧孟勤)
http://codereview.chromium.org/57065/diff/1/2 File build/install-build-deps.sh (right): http://codereview.chromium.org/57065/diff/1/2#newcode105 Line 105: ${pkg_list} ${lib_list} ${dbg_list} ${dev_list} \ I suspect, the ...
11 years, 8 months ago (2009-03-31 19:20:12 UTC) #2
Lei Zhang
Ping. Waiting for the rubber stamp.
11 years, 8 months ago (2009-04-03 01:34:29 UTC) #3
Markus (顧孟勤)
11 years, 8 months ago (2009-04-03 01:39:19 UTC) #4
LGTM

Oh, sorry, I didn't know you still needed me to look at it again.

Powered by Google App Engine
This is Rietveld 408576698