Issue 57062: Use portable typedef for PIDs (process IDs).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57062: Use portable typedef for PIDs (process IDs). (Closed)

Created:
11 years, 8 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
tommi (sloooow) - chröme, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Use portable typedef for PIDs (process IDs). This is a preparation to land http://codereview.chromium.org/54003, which replaces chrome_process_filter with more portable chrome_process_util. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12948

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix windows build, try DWORD #

Patch Set 3 : add comment #

Patch Set 4 : speculative fix for win #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -19 lines)			Patch
M	base/process.h	View	1 2	3 chunks	+6 lines, -2 lines	0 comments	Download
M	base/process_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	base/process_util.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	base/process_util_posix.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/process_util_win.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	base/process_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_process_filter.h	View	2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_process_filter.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM http://codereview.chromium.org/57062/diff/1/2 File base/process.h (right): http://codereview.chromium.org/57062/diff/1/2#newcode18 Line 18: // handle to a process. You should ...

11 years, 8 months ago (2009-03-31 17:30:04 UTC) #2

tommi (sloooow) - chröme

11 years, 8 months ago (2009-03-31 17:38:54 UTC) #3

rubber stamp lgtm

good to see this being defined finally.
I believe Stoyan attempted this sometime ago but reverted it for some reason. 
Maybe you should ping him just in case there's something we're missing.

http://codereview.chromium.org/57062/diff/1/2
File base/process.h (right):

http://codereview.chromium.org/57062/diff/1/2#newcode21
Line 21: typedef int ProcessId;
process id is DWORD on Windows.

Expand Messages | Collapse Messages