Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: chrome/common/child_thread.cc

Issue 5706001: An exprimental fix for Bug 65940.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_thread.cc
===================================================================
--- chrome/common/child_thread.cc (revision 68724)
+++ chrome/common/child_thread.cc (working copy)
@@ -71,6 +71,11 @@
channel_->RemoveFilter(sync_message_filter_.get());
+ // Close this channel before resetting the message loop attached to it so
+ // the message loop can call ChannelProxy::Context::OnChannelClosed(), which
+ // releases the reference count to this channel.
+ channel_->Close();
+
// The ChannelProxy object caches a pointer to the IPC thread, so need to
// reset it as it's not guaranteed to outlive this object.
// NOTE: this also has the side-effect of not closing the main IPC channel to
« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698