Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8114)

Unified Diff: chrome/browser/dom_ui/foreign_session_handler.h

Issue 5705004: [SYNC] Sessions datatype refactor. Most things related to sessions under-the-... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Rebase Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/dom_ui/foreign_session_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/foreign_session_handler.h
===================================================================
--- chrome/browser/dom_ui/foreign_session_handler.h (revision 70604)
+++ chrome/browser/dom_ui/foreign_session_handler.h (working copy)
@@ -37,22 +37,21 @@
// Returns a pointer to the current session model associator or NULL.
SessionModelAssociator* GetModelAssociator();
+ // Determines which session is to be opened, and then calls
+ // OpenForeignSession, to begin the process of opening a new browser window.
+ // This is a javascript callback handler.
+ void HandleOpenForeignSession(const ListValue* args);
+
// Determines whether foreign sessions should be obtained from the sync model.
// This is a javascript callback handler, and it is also called when the sync
// model has changed and the new tab page needs to reflect the changes.
void HandleGetForeignSessions(const ListValue* args);
- // Helper for reopening a foreign session in a new browser window.
- void OpenForeignSession(SessionModelAssociator* associator, int64 id);
+ // Helper methods to create JSON compatible objects from Session objects.
+ bool SessionTabToValue(const SessionTab& tab, DictionaryValue* dictionary);
+ bool SessionWindowToValue(const SessionWindow& window,
+ DictionaryValue* dictionary);
- // Helper for listing the foreign sessions on the new tab page.
- void GetForeignSessions(SessionModelAssociator* associator);
-
- // Determines which session is to be opened, and then calls
- // OpenForeignSession, to begin the process of opening a new browser window.
- // This is a javascript callback handler.
- void HandleReopenForeignSession(const ListValue* args);
-
// The Registrar used to register ForeignSessionHandler for notifications.
NotificationRegistrar registrar_;
« no previous file with comments | « no previous file | chrome/browser/dom_ui/foreign_session_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698