[SYNC] Sessions datatype refactor. Most things related to sessions under-the-...

chrome/browser/sessions/session_types.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SESSIONS_SESSION_TYPES_H_
 #define CHROME_BROWSER_SESSIONS_SESSION_TYPES_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/stl_util-inl.h"
 #include "base/string16.h"
+#include "base/time.h"
 #include "chrome/browser/sessions/session_id.h"
 #include "chrome/common/page_transition_types.h"
 #include "gfx/rect.h"
 #include "googleurl/src/gurl.h"
 
 class NavigationEntry;
 class Profile;
 
 // TabNavigation  -------------------------------------------------------------
 
@@ skipping 90 matching lines @@
   // restore, others can likely ignore this and use the order of the
   // tabs in SessionWindow.tabs.
   int tab_visual_index;
 
   // Identifies the index of the current navigation in navigations. For
   // example, if this is 2 it means the current navigation is navigations[2].
   //
   // NOTE: when the service is creating SessionTabs, initially this
   // corresponds to TabNavigation.index, not the index in navigations. When done
   // creating though, this is set to the index in navigations.
+  //
+  // NOTE 2: this value can be larger than the size of |navigations|, due to
+  // only valid url's being stored (ie chrome://newtab is not stored). Bounds
+  // checking must be performed before indexing into |navigations|.
   int current_navigation_index;
 
   // True if the tab is pinned.
   bool pinned;
 
   // If non-empty, this tab is an app tab and this is the id of the extension.
   std::string extension_app_id;
 
+  // Timestamp for when this tab was last modified.
+  base::Time timestamp;
+
   std::vector<TabNavigation> navigations;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SessionTab);
 };
 
 // SessionWindow -------------------------------------------------------------
 
 // Describes a saved window.
 struct SessionWindow {
@@ skipping 19 matching lines @@
   // TYPE_NORMAL and TYPE_POPUP.
   // This would be Browser::Type, but that would cause a circular dependency.
   int type;
 
   // If true, the window is constrained.
   //
   // Currently SessionService prunes all constrained windows so that session
   // restore does not attempt to restore them.
   bool is_constrained;
 
+  // Timestamp for when this window was last modified.
+  base::Time timestamp;
+
   // The tabs, ordered by visual order.
   std::vector<SessionTab*> tabs;
 
   // Is the window maximized?
   bool is_maximized;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SessionWindow);
 };
 
 // Defines a foreign session for session sync.  A foreign session is a session
 // on a remote chrome instance.
 struct ForeignSession {
   ForeignSession();
   ~ForeignSession();
 
   // Unique tag for each session.
   std::string foreign_session_tag;
   std::vector<SessionWindow*> windows;
 };
 
 #endif  // CHROME_BROWSER_SESSIONS_SESSION_TYPES_H_