Issue 57049: Mark a bunch of places where we enter or leave V8 through the API....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57049: Mark a bunch of places where we enter or leave V8 through the API.... (Closed)

Created:
11 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Mark a bunch of places where we enter or leave V8 through the API. Indiscriminately mark every place with EnsureInitialized, ON_BAILOUT, or IsDeadCheck (even if they cannot write to V8's heap). Also mark callbacks, and one other place (Function::SetName) hit in Chromium. Committed: http://code.google.com/p/v8/source/detail?r=1647

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -5 lines)			Patch
	M	src/api.cc	View		155 chunks	+191 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

I'm not sure I've got them all, but it runs in the browser. It's actually ...

11 years, 8 months ago (2009-03-31 09:01:11 UTC) #1

LGTM

Expand Messages | Collapse Messages