Issue 5704002: Suppress memory leaks in MalwareDetailsTest introduced in r68828

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5704002: Suppress memory leaks in MalwareDetailsTest introduced in r68828 (Closed)

Created:
10 years ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko, panayiotis

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/tools/valgrind/memcheck

Visibility:
Public.

Description

Suppress memory leaks in MalwareDetailsTest introduced in r68828 BUG=66277 TEST=less redness on memory bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68843

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years ago (2010-12-10 12:01:53 UTC) #2

LGTM

On Fri, Dec 10, 2010 at 2:56 PM,  <jochen@chromium.org> wrote:
> Reviewers: Alexander Potapenko, panayiotis,
>
> Message:
> please review
>
> Description:
> Suppress memory leaks in MalwareDetailsTest introduced in r68828
>
> BUG=66277
> TEST=less redness on memory bots
>
> Please review this at http://codereview.chromium.org/5704002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/tools/valgrind/memcheck
>
> Affected files:
>  M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
90c7c6db51c12cbcebc9b59de2a6d204d566300e..70f44186d1c128bf17a81a4246205e8c0cddf32d
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -3491,3 +3491,9 @@
>    fun:_Znw*
>
>  fun:_ZN6policy47AsynchronousPolicyTestBase_ProviderRefresh_Test8TestBodyEv
>  }
> +{
> +   bug_66277
> +   Memcheck:Leak
> +   ...
> +   fun:*MalwareDetailsTest_*
> +}
>
>
>

Expand Messages | Collapse Messages