Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3678)

Unified Diff: chrome/renderer/render_widget.cc

Issue 57032: Implement HTML selects as native Cocoa controls for Chrome (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_widget.cc
===================================================================
--- chrome/renderer/render_widget.cc (revision 14463)
+++ chrome/renderer/render_widget.cc (working copy)
@@ -313,7 +313,7 @@
// If there is a custom background, tile it.
if (!background_.empty()) {
canvas->save();
-
+
SkIRect clipRect = { rect.x(), rect.y(), rect.right(), rect.bottom() };
canvas->setClipRegion(SkRegion(clipRect));
@@ -589,8 +589,13 @@
int item_height,
int selected_index,
const std::vector<WebMenuItem>& items) {
- // TODO(paulg): Implement this for Mac HTML select menus in Chromium, bug
- // number: http://crbug.com/8389
+ ViewHostMsg_ShowPopup_Params params;
+ params.bounds = bounds;
+ params.item_height = item_height;
+ params.selected_item = selected_index;
+ params.popup_items = items;
+
+ Send(new ViewHostMsg_ShowPopup(routing_id_, params));
}
void RenderWidget::Focus(WebWidget* webwidget) {
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698