Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 57032: Implement HTML selects as native Cocoa controls for Chrome (Closed)

Created:
11 years, 8 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
Amanda Walker
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implement HTML selects as native Cocoa controls for Chrome. BUG=8389 (http://crbug.com/8389) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14471

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Patch Set 14 : '' #

Patch Set 15 : '' #

Patch Set 16 : '' #

Patch Set 17 : '' #

Patch Set 18 : '' #

Total comments: 1

Patch Set 19 : '' #

Patch Set 20 : '' #

Patch Set 21 : '' #

Patch Set 22 : '' #

Patch Set 23 : '' #

Patch Set 24 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -6 lines) Patch
M chrome/browser/renderer_host/render_widget_host.h View 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 11 12 13 14 15 16 17 18 19 20 21 22 23 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.h View 11 12 13 14 15 16 17 18 19 20 21 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 11 12 13 14 15 16 17 18 19 20 21 3 chunks +39 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/test_render_view_host.h View 11 12 13 14 15 16 17 18 19 20 21 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 13 14 15 16 17 18 19 20 21 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +105 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/render_widget.cc View 1 2 3 4 5 6 7 8 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
This review depends on the test_shell cocoa menu delegate refactor: http://codereview.chromium.org/92062
11 years, 8 months ago (2009-04-23 22:00:51 UTC) #1
Amanda Walker
11 years, 8 months ago (2009-04-24 14:34:59 UTC) #2
Generally LGTM, with one footprint nit.

http://codereview.chromium.org/57032/diff/7111/7118
File chrome/browser/renderer_host/render_widget_host_view.h (right):

http://codereview.chromium.org/57032/diff/7111/7118#newcode141
Line 141: const std::vector<WebMenuItem>& items) = 0;
I'd wrap this in #if defined(OS_MACOSX) (and remove the corresponding dummy
methods for non-Mac implementations) rather than have a bunch of dummy methods
that just call NOTREACHED()), unless we have reason to believe that the other
platforms will want to use this capability in the near future.

Powered by Google App Engine
This is Rietveld 408576698