Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 5703005: An attempt to fix the flakiness with the ChromeFrame Javascript window open t... (Closed)

Created:
10 years ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

An attempt to fix the flakiness with the ChromeFrame Javascript window open test on IE9. We receive multiple NavigateComplete notifications at times. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome_frame/test/mock_ie_event_sink_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years ago (2010-12-13 22:18:34 UTC) #1
amit
10 years ago (2010-12-13 22:20:49 UTC) #2
ok, Thanks for fixing the long running failure!

On Mon, Dec 13, 2010 at 2:18 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> An attempt to fix the flakiness with the ChromeFrame Javascript window open
> test
> on IE9.
>
> We receive multiple NavigateComplete notifications at times.
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/5703005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/mock_ie_event_sink_test.cc
>
>
> Index: chrome_frame/test/mock_ie_event_sink_test.cc
> ===================================================================
> --- chrome_frame/test/mock_ie_event_sink_test.cc        (revision 68895)
> +++ chrome_frame/test/mock_ie_event_sink_test.cc        (working copy)
> @@ -94,7 +94,7 @@
>
>  void MockIEEventSink::ExpectNavigation(bool is_cf, const std::wstring&
> url) {
>   InSequence expect_in_sequence_for_scope;
> -  if (is_cf) {
> +  if (is_cf || GetInstalledIEVersion() == IE_9) {
>     ExpectNavigationCardinality(url, Exactly(1), testing::Between(1, 2));
>   } else {
>     ExpectNavigationCardinality(url, Exactly(1), Exactly(1));
>
>
>

Powered by Google App Engine
This is Rietveld 408576698