Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Unified Diff: chrome/browser/autofill/autofill_download.cc

Issue 5703002: Add some basic success/failure UMA logging for autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Hopefully compile on Windows Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_download.cc
diff --git a/chrome/browser/autofill/autofill_download.cc b/chrome/browser/autofill/autofill_download.cc
index 9b2e747ccc0f839dd9cadd821fa5d8c9fc9793a2..1b209278f9c0f149044e24812b58fb2f4a8e67ff 100644
--- a/chrome/browser/autofill/autofill_download.cc
+++ b/chrome/browser/autofill/autofill_download.cc
@@ -67,7 +67,8 @@ void AutoFillDownloadManager::SetObserver(
}
bool AutoFillDownloadManager::StartQueryRequest(
- const ScopedVector<FormStructure>& forms) {
+ const ScopedVector<FormStructure>& forms,
+ const AutoFillServerQueryMetricLogger& server_query_metric_logger) {
if (next_query_request_ > base::Time::Now()) {
// We are in back-off mode: do not do the request.
return false;
@@ -79,7 +80,7 @@ bool AutoFillDownloadManager::StartQueryRequest(
return false;
request_data.request_type = AutoFillDownloadManager::REQUEST_QUERY;
- autofill_metrics::LogServerQueryMetric(autofill_metrics::QUERY_SENT);
+ server_query_metric_logger.Log(AutoFillServerQueryMetricLogger::QUERY_SENT);
return StartRequest(form_xml, request_data);
}

Powered by Google App Engine
This is Rietveld 408576698