Add some basic success/failure UMA logging for autofill.

chrome/browser/autofill/autofill_download_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <list>
 
 #include "base/string_util.h"
 #include "base/test/test_timeouts.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_download.h"
+#include "chrome/browser/autofill/autofill_metrics.h"
 #include "chrome/common/net/test_url_fetcher_factory.h"
 #include "chrome/test/testing_profile.h"
 #include "net/url_request/url_request_status.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebInputElement.h"
 #include "webkit/glue/form_data.h"
 
 using webkit_glue::FormData;
 using WebKit::WebInputElement;
 
+namespace {
+
+class MockAutoFillServerQueryMetricLogger :
+    public AutoFillServerQueryMetricLogger {
+ public:
+  // TODO(isherman): Use gmock instead and test that metrics are logged as we'd

[dhollowa, 2010/12/12 07:07:51]

Let's use gmock now.

[Ilya Sherman, 2010/12/13 22:13:51]

Done.

+  // expect.
+  virtual void Log(Metric metric) const OVERRIDE {}
+};
+
+}  // namespace
+
 // This tests AutoFillDownloadManager. AutoFillDownloadTestHelper implements
 // AutoFillDownloadManager::Observer and creates an instance of
 // AutoFillDownloadManager. Then it records responses to different initiated
 // requests, which are verified later. To mock network requests
 // TestURLFetcherFactory is used, which creates URLFetchers that do not
 // go over the wire, but allow calling back HTTP responses directly.
 // The responses in test are out of order and verify: successful query request,
 // successful upload request, failed upload request.
 class AutoFillDownloadTestHelper : public AutoFillDownloadManager::Observer {
  public:
@@ skipping 48 matching lines @@
     std::string response;
     ResponseData() : type_of_response(REQUEST_QUERY_FAILED), error(0) {
     }
   };
   std::list<AutoFillDownloadTestHelper::ResponseData> responses_;
 
   TestingProfile profile;
   AutoFillDownloadManager download_manager;
 };
 
-namespace {
-
 TEST(AutoFillDownloadTest, QueryAndUploadTest) {
   MessageLoopForUI message_loop;
   // Create and register factory.
   AutoFillDownloadTestHelper helper;
   TestURLFetcherFactory factory;
   URLFetcher::set_factory(&factory);
 
   FormData form;
   form.method = ASCIIToUTF16("post");
   form.fields.push_back(webkit_glue::FormField(ASCIIToUTF16("username"),
@@ skipping 65 matching lines @@
   form.fields.push_back(webkit_glue::FormField(string16(),
                                                ASCIIToUTF16("Submit"),
                                                string16(),
                                                ASCIIToUTF16("submit"),
                                                0,
                                                false));
   form_structure = new FormStructure(form);
   form_structures.push_back(form_structure);
 
   // Request with id 0.
-  EXPECT_TRUE(helper.download_manager.StartQueryRequest(form_structures));
+  EXPECT_TRUE(helper.download_manager.StartQueryRequest(
+      form_structures,
+      MockAutoFillServerQueryMetricLogger()));
   // Set upload to 100% so requests happen.
   helper.download_manager.SetPositiveUploadRate(1.0);
   helper.download_manager.SetNegativeUploadRate(1.0);
   // Request with id 1.
   EXPECT_TRUE(helper.download_manager.StartUploadRequest(*(form_structures[0]),
                                                          true));
   // Request with id 2.
   EXPECT_TRUE(helper.download_manager.StartUploadRequest(*(form_structures[1]),
                                                          false));
 
@@ skipping 64 matching lines @@
   helper.download_manager.SetNegativeUploadRate(0.0);
   // No actual requests for the next two calls, as we set upload rate to 0%.
   EXPECT_FALSE(helper.download_manager.StartUploadRequest(*(form_structures[0]),
                                                          true));
   EXPECT_FALSE(helper.download_manager.StartUploadRequest(*(form_structures[1]),
                                                          false));
   fetcher = factory.GetFetcherByID(3);
   EXPECT_EQ(NULL, fetcher);
 
   // Request with id 3.
-  EXPECT_TRUE(helper.download_manager.StartQueryRequest(form_structures));
+  EXPECT_TRUE(helper.download_manager.StartQueryRequest(
+      form_structures,
+      MockAutoFillServerQueryMetricLogger()));
   fetcher = factory.GetFetcherByID(3);
   ASSERT_TRUE(fetcher);
   fetcher->set_backoff_delay(
       base::TimeDelta::FromMilliseconds(TestTimeouts::action_max_timeout_ms()));
   fetcher->delegate()->OnURLFetchComplete(fetcher, GURL(), URLRequestStatus(),
                                           500, ResponseCookies(),
                                           std::string(responses[0]));
   EXPECT_EQ(AutoFillDownloadTestHelper::REQUEST_QUERY_FAILED,
             helper.responses_.front().type_of_response);
   EXPECT_EQ(500, helper.responses_.front().error);
   // Expected response on non-query request is an empty string.
   EXPECT_EQ(std::string(), helper.responses_.front().response);
   helper.responses_.pop_front();
 
   // Query requests should be ignored for the next 10 seconds.
-  EXPECT_FALSE(helper.download_manager.StartQueryRequest(form_structures));
+  EXPECT_FALSE(helper.download_manager.StartQueryRequest(
+      form_structures,
+      MockAutoFillServerQueryMetricLogger()));
   fetcher = factory.GetFetcherByID(4);
   EXPECT_EQ(NULL, fetcher);
 
   // Set upload to 100% so requests happen.
   helper.download_manager.SetPositiveUploadRate(1.0);
   // Request with id 4.
   EXPECT_TRUE(helper.download_manager.StartUploadRequest(*(form_structures[0]),
               true));
   fetcher = factory.GetFetcherByID(4);
   ASSERT_TRUE(fetcher);
   fetcher->set_backoff_delay(
       base::TimeDelta::FromMilliseconds(TestTimeouts::action_max_timeout_ms()));
   fetcher->delegate()->OnURLFetchComplete(fetcher, GURL(), URLRequestStatus(),
                                           503, ResponseCookies(),
                                           std::string(responses[2]));
   EXPECT_EQ(AutoFillDownloadTestHelper::REQUEST_UPLOAD_FAILED,
             helper.responses_.front().type_of_response);
   EXPECT_EQ(503, helper.responses_.front().error);
   helper.responses_.pop_front();
 
   // Upload requests should be ignored for the next 10 seconds.
   EXPECT_FALSE(helper.download_manager.StartUploadRequest(*(form_structures[0]),
               true));
   fetcher = factory.GetFetcherByID(5);
   EXPECT_EQ(NULL, fetcher);
 
   // Make sure consumer of URLFetcher does the right thing.
   URLFetcher::set_factory(NULL);
 }
-
-}  // namespace