Issue 57026: DEPS roll to get latest gyp rev.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57026: DEPS roll to get latest gyp rev. (Closed)

Created:
11 years, 8 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DEPS roll to get latest gyp rev. Also, Windows update to common.gypi to accommodate msvs.py change in gyp r405. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12830

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	build/common.gypi	View	2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sgk

bradnelson's CL to use include_dirs for resource compiles. Line-length-limitation workaround. Print stderr on failed command ...

11 years, 8 months ago (2009-03-30 21:26:43 UTC) #1

sgk

Update: changes common.gypi so the Windows build works with r405. Trybot initially failed, now passes ...

11 years, 8 months ago (2009-03-30 22:11:16 UTC) #2

Mark Mentovai

http://codereview.chromium.org/57026/diff/1002/5 File build/common.gypi (right): http://codereview.chromium.org/57026/diff/1002/5#newcode294 Line 294: 'AdditionalIncludeDirectories': ['<(DEPTH)'], LG

11 years, 8 months ago (2009-03-30 22:26:24 UTC) #4

sgk

TBR: mark Incremented one more rev to get the latest change re: target names on ...

11 years, 8 months ago (2009-03-31 01:11:45 UTC) #5

LG still

Expand Messages | Collapse Messages