Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: net/proxy/proxy_service_unittest.cc

Issue 57011: Extract the parsing of proxy rules to ProxyConfig::ProxyRules, and unit-test.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address wtc's second batch of comments -- second try, got rietveld 500 before... Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_service_unittest.cc
===================================================================
--- net/proxy/proxy_service_unittest.cc (revision 12729)
+++ net/proxy/proxy_service_unittest.cc (working copy)
@@ -687,7 +687,7 @@
// Test what happens when a proxy bypass list is specified.
net::ProxyConfig config;
- config.proxy_rules = "foopy1:8080;foopy2:9090";
+ config.proxy_rules.ParseFromString("foopy1:8080;foopy2:9090");
config.auto_detect = false;
config.proxy_bypass_local_names = true;
@@ -767,7 +767,7 @@
TEST(ProxyServiceTest, PerProtocolProxyTests) {
net::ProxyConfig config;
- config.proxy_rules = "http=foopy1:8080;https=foopy2:8080";
+ config.proxy_rules.ParseFromString("http=foopy1:8080;https=foopy2:8080");
config.auto_detect = false;
SyncProxyService service1(new MockProxyConfigService(config),
@@ -797,7 +797,7 @@
EXPECT_FALSE(info3.is_direct());
EXPECT_EQ("foopy2:8080", info3.proxy_server().ToURI());
- config.proxy_rules = "foopy1:8080";
+ config.proxy_rules.ParseFromString("foopy1:8080");
SyncProxyService service4(new MockProxyConfigService(config),
new MockProxyResolver);
GURL test_url4("www.microsoft.com");
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698