net/proxy/proxy_server.h - Issue 57011: Extract the parsing of proxy rules to ProxyConfig::ProxyRules, and unit-test....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_server.h

Issue 57011: Extract the parsing of proxy rules to ProxyConfig::ProxyRules, and unit-test.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: address wtc's second batch of comments -- second try, got rietveld 500 before... Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_server.h

===================================================================

--- net/proxy/proxy_server.h (revision 12729)

+++ net/proxy/proxy_server.h (working copy)

@@ -103,6 +103,12 @@

// scheme. Returns -1 if unknown.

static int GetDefaultPortForScheme(Scheme scheme);

+ bool operator==(const ProxyServer& other) const {

+ return scheme_ == other.scheme_ &&

+ host_ == other.host_ &&

+ port_ == other.port_;

+ }

private:

// Create a ProxyServer given a scheme, and host/port string. If parsing the

// host/port string fails, the returned instance will be invalid.

« no previous file with comments | « net/proxy/proxy_resolver_mac.cc ('k') | net/proxy/proxy_service.h » ('j') | no next file with comments »