Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/policy/configuration_policy_pref_store.h

Issue 5701003: Intorduce a separate preference for 'proxy server mode' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indentation nit Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/configuration_policy_pref_store.h
diff --git a/chrome/browser/policy/configuration_policy_pref_store.h b/chrome/browser/policy/configuration_policy_pref_store.h
index 820306aa74fdf0c4374d4e420639faf85557be28..40854b28f188a03b9c98e75896ed592285345f02 100644
--- a/chrome/browser/policy/configuration_policy_pref_store.h
+++ b/chrome/browser/policy/configuration_policy_pref_store.h
@@ -56,10 +56,6 @@ class ConfigurationPolicyPrefStore : public PrefStore,
static const ConfigurationPolicyProvider::PolicyDefinitionList*
GetChromePolicyDefinitionList();
- // Returns the set of preference paths that can be affected by a proxy
- // policy.
- static void GetProxyPreferenceSet(ProxyPreferenceSet* proxy_pref_set);
-
private:
// Policies that map to a single preference are handled
// by an automated converter. Each one of these policies
@@ -84,19 +80,6 @@ class ConfigurationPolicyPrefStore : public PrefStore,
// to override any values set from stores with a lower priority.
bool lower_priority_proxy_settings_overridden_;
- // The following are used to track what proxy-relevant policy has been applied
- // accross calls to Apply to provide a warning if a policy specifies a
- // contradictory proxy configuration. |proxy_disabled_| is set to true if and
- // only if the kPolicyNoProxyServer has been applied,
- // |proxy_configuration_specified_| is set to true if and only if any other
- // proxy policy other than kPolicyNoProxyServer has been applied.
- bool proxy_disabled_;
- bool proxy_configuration_specified_;
-
- // Set to true if a the proxy mode policy has been set to force Chrome
- // to use the system proxy.
- bool use_system_proxy_;
-
// Returns the map entry that corresponds to |policy| in the map.
const PolicyToPreferenceMapEntry* FindPolicyInMap(
ConfigurationPolicyType policy,
@@ -136,6 +119,10 @@ class ConfigurationPolicyPrefStore : public PrefStore,
// map entries from |prefs_|.
void FinalizeDefaultSearchPolicySettings();
+ // Returns true if the preference at the given path exists and has a non-null
+ // value.
+ bool NonNullValueExists(const std::string& path);
+
DISALLOW_COPY_AND_ASSIGN(ConfigurationPolicyPrefStore);
};

Powered by Google App Engine
This is Rietveld 408576698