Intorduce a separate preference for 'proxy server mode'

chrome/browser/extensions/extension_proxy_api.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_PROXY_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_PROXY_API_H_
 
 #include <string>
 
 #include "chrome/browser/extensions/extension_function.h"
@@ skipping 15 matching lines @@
     ProxyServer() : scheme("http"), host(""), port(INVALID_PORT) {}
 
     // The scheme of the proxy URI itself.
     std::string scheme;
     std::string host;
     int port;
   };
 
   bool GetProxyServer(const DictionaryValue* dict, ProxyServer* proxy_server);
 
-  bool ApplyAutoDetect(bool auto_detect);
+  bool ApplyMode(int mode);

[battre (please use the other), 2010/12/14 09:45:44]

Insert reference to mode definitions? Should we make this a string rather than
int?

[danno, 2010/12/14 12:48:17]

I think an enum would be better internally. 

On 2010/12/14 09:45:44, battre wrote:

[gfeher, 2010/12/16 10:42:04]

I'll do the string->enum conversion inside this method, becuase other Apply*
methods tend to do similar things.

   bool ApplyPacScript(DictionaryValue* pac_dict);
   bool ApplyProxyRules(DictionaryValue* proxy_rules);
 
   // Sends a notification that the given pref would like to change to the
   // indicated pref_value. This is mainly useful so the ExtensionPrefStore can
   // apply the requested change.
   void SendNotification(const char* pref_path, Value* pref_value);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_PROXY_API_H_