Intorduce a separate preference for 'proxy server mode'

chrome/browser/prefs/proxy_prefs.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_PROXY_PREFS_H_
+#define CHROME_BROWSER_PREFS_PROXY_PREFS_H_
+#pragma once
+
+#include <string>
+
+class ProxyPrefs {

[danno, 2010/12/16 16:29:29]

Put these in the prefs namespace

[gfeher, 2010/12/16 23:54:29]

The prefs namespace currently only contains the const chars of preference paths.
I would defer messing with this to another CL.

+ public:
+  // Possible types of specifying proxy settings. Do not change the order of
+  // the constants, because numeric values are exposed to users.
+  enum ProxyServerMode {
+    // Direct connection to the network, other proxy preferences are ignored.
+    DISABLED,

[danno, 2010/12/16 16:29:29]

In order to not pollute the namespace, prefix with PROXY_

[danno, 2010/12/16 16:29:29]

Maybe add specific = values here? might obviate the need for IntToMode?

[gfeher, 2010/12/16 23:54:29]

extension.h and session_startup_pref.h have similar enums defined. The only
difference is that they not only have static members, but also some non-static
ones.

[gfeher, 2010/12/16 23:54:29]

Specific int values are encouraged by the style guide. However, I like IntToMode
because it puts range-checking at one place, but I would be okay with removing
it.

+
+    // Try to retrieve proxy settings from the following sources in the
+    // following order:
+    //  1. http://wpad/wpad.dat
+    //  2. The PAC script at kProxyPacUrl.
+    //  3. The settings specified in kProxyServer and kProxyBypassList
+    AUTO_DETECT,
+
+    // Same as AUTO_DETECT except that 1. is always skipped.
+    MANUAL,
+
+    // The system's proxy settings are used, other proxy preferences are
+    // ignored.
+    SYSTEM

[danno, 2010/12/16 16:29:29]

Add "PROXY_MODE_COUNT"

[gfeher, 2010/12/16 23:54:29]

Done.

+  };
+
+  static bool IntToMode(int in_value, ProxyServerMode* out_value);

[danno, 2010/12/16 16:29:29]

IntToProxyMode

[gfeher, 2010/12/16 23:54:29]

Done.

+  static bool StringToMode(const std::string& in_value,

[danno, 2010/12/16 16:29:29]

StringToProxyMode

[gfeher, 2010/12/16 23:54:29]

Done.

+                           ProxyServerMode* out_value);
+};
+
+#endif  // CHROME_BROWSER_PREFS_PROXY_PREFS_H_