Intorduce a separate preference for 'proxy server mode'

chrome/browser/prefs/proxy_prefs.cc

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/prefs/proxy_prefs.h"
+
+#include "base/basictypes.h"
+#include "base/logging.h"
+
+namespace {
+  // These names are exposed to the proxy extension API. They must be in sync
+  // with the constants of ProxyPrefs.
+  const char* kProxyModeNames[] = { "disabled",
+                                    "auto_detect",
+                                    "manual",
+                                    "system" };
+}  // namespace
+
+COMPILE_ASSERT(arraysize(kProxyModeNames) == ProxyPrefs::NUM_MODES,
+               kProxyModeNames_must_have_size_of_NUM_MODES);
+
+// static
+bool ProxyPrefs::IntToProxyMode(
+    int in_value,
+    ProxyPrefs::ProxyServerMode* out_value) {

[Mattias Nissler (ping if slow), 2010/12/20 13:34:03]

Do these fit on the opening parentheses line?

[battre (please use the other), 2010/12/21 14:18:18]

Done.

+  DCHECK(out_value);
+  if (in_value < 0 || in_value >= ProxyPrefs::NUM_MODES) {
+    return false;
+  }
+  *out_value = static_cast<ProxyPrefs::ProxyServerMode>(in_value);
+  return true;
+}
+
+// static
+bool ProxyPrefs::StringToProxyMode(
+    const std::string& in_value,
+    ProxyPrefs::ProxyServerMode* out_value) {

[Mattias Nissler (ping if slow), 2010/12/20 13:34:03]

same here?

[battre (please use the other), 2010/12/21 14:18:18]

Done.

+  DCHECK(out_value);
+  for (int i = 0; i < ProxyPrefs::NUM_MODES; i++) {
+    if (in_value == kProxyModeNames[i]) {
+      return IntToProxyMode(i, out_value);
+    }
+  }
+  return false;
+}