Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 57006: Initialize list of frame elements to proper size. (Closed)

Created:
11 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Initialize list of frame elements to proper size. Committed: http://code.google.com/p/v8/source/detail?r=1641

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/list.h View 2 2 chunks +2 lines, -1 line 0 comments Download
M src/virtual-frame.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M src/virtual-frame-arm.h View 2 2 chunks +2 lines, -1 line 0 comments Download
M src/virtual-frame-arm.cc View 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/virtual-frame-ia32.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/virtual-frame-ia32.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
William Hesse
A tiny change for you
11 years, 9 months ago (2009-03-30 09:23:54 UTC) #1
Kevin Millikin (Chromium)
You may want to consider doing something with the other constructor (copying an existing frame) ...
11 years, 8 months ago (2009-03-30 09:51:36 UTC) #2
William Hesse
On 2009/03/30 09:51:36, Kevin Millikin wrote: > You may want to consider doing something with ...
11 years, 8 months ago (2009-03-30 12:29:15 UTC) #3
Kevin Millikin (Chromium)
11 years, 8 months ago (2009-03-30 12:51:41 UTC) #4
LGTM.  You've changed the copyright date on one file, but not all of them.  That
seems inconsistent.

Powered by Google App Engine
This is Rietveld 408576698