Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: trychange.py

Issue 570059: Make git-try --webkit work like it used to work. (Closed)
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 31275dbb6c103561de69030d447411110d5f905d..2f3432641887b4d35e6443dc076a38a76cc610bf 100755
--- a/trychange.py
+++ b/trychange.py
@@ -512,10 +512,18 @@ def TryChange(argv,
"revision/branch to diff against.")
# Mostly chromium-specific
try:
- group.add_option("--webkit", action="append_const",
- const="third_party/WebKit",
- dest="PATH",
- help="Shorthand for -s third_party/WebKit")
+ def WebKitRevision(options, opt, value, parser):
+ if parser.rargs and not parser.rargs[0].startswith('-'):
+ options.sub_rep.append('third_party/WebKit@%s' % parser.rargs.pop(0))
+ else:
+ options.sub_rep.append('third_party/WebKit')
+
+ group.add_option("-W", "--webkit", action="callback",
+ callback=WebKitRevision,
+ metavar="BRANCH",
+ help="Shorthand for -s third_party/WebKit@BRANCH. "
+ "BRANCH is optional and is the branch the current "
+ "checkout will be diff'ed against.")
except optparse.OptionError:
# append_const is not supported on 2.4. Too bad.
pass
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698