Add os.chdir and os.setenv to d8. Move system() to os.system().

src/d8-posix.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 166 matching lines @@
  private:
   int fd_;
 };
 
 
 // A utility class that takes the array of command arguments and puts then in an
 // array of new[]ed UTF-8 C strings.  Deallocates them again when it goes out of
 // scope.
 class ExecArgs {
  public:
-  ExecArgs(Handle<Value> arg0, Handle<Array> command_args) {
+  ExecArgs() {
+    exec_args_[0] = NULL;
+  }
+  bool Init(Handle<Value> arg0, Handle<Array> command_args) {
     String::Utf8Value prog(arg0);
-    int len = prog.length() + 1;
+    if (*prog == NULL) {
+      const char* message =
+          "os.system(): String conversion of program name failed";
+      ThrowException(String::New(message));
+      return false;
+    }
+    int len = prog.length() + 3;
     char* c_arg = new char[len];
     snprintf(c_arg, len, "%s", *prog);
     exec_args_[0] = c_arg;
     int i = 1;
     for (unsigned j = 0; j < command_args->Length(); i++, j++) {
       Handle<Value> arg(command_args->Get(Integer::New(j)));
       String::Utf8Value utf8_arg(arg);
+      if (*utf8_arg == NULL) {
+        exec_args_[i] = NULL;  // Consistent state for destructor.
+        const char* message =
+            "os.system(): String conversion of argument failed.";
+        ThrowException(String::New(message));
+        return false;
+      }
       int len = utf8_arg.length() + 1;
       char* c_arg = new char[len];
       snprintf(c_arg, len, "%s", *utf8_arg);
       exec_args_[i] = c_arg;
     }
     exec_args_[i] = NULL;
+    return true;
   }
   ~ExecArgs() {
     for (unsigned i = 0; i < kMaxArgs; i++) {
       if (exec_args_[i] == NULL) {
         return;
       }
       delete [] exec_args_[i];
       exec_args_[i] = 0;
     }
   }
@@ skipping 234 matching lines @@
   if (command_args->Length() > ExecArgs::kMaxArgs) {
     return ThrowException(String::New("Too many arguments to system()"));
   }
   if (args.Length() < 1) {
     return ThrowException(String::New("Too few arguments to system()"));
   }
 
   struct timeval start_time;
   gettimeofday(&start_time, NULL);
 
-  ExecArgs exec_args(args[0], command_args);
+  ExecArgs exec_args;
+  if (!exec_args.Init(args[0], command_args)) {
+    return v8::Undefined();
+  }
   int exec_error_fds[2];
   int stdout_fds[2];
 
   if (pipe(exec_error_fds) != 0) {
     return ThrowException(String::New("pipe syscall failed."));
   }
   if (pipe(stdout_fds) != 0) {
     return ThrowException(String::New("pipe syscall failed."));
   }
 
@@ skipping 26 matching lines @@
                     start_time,
                     read_timeout,
                     total_timeout)) {
     return v8::Undefined();
   }
 
   return scope.Close(accumulator);
 }
 
 
+Handle<Value> Shell::ChangeDirectory(const Arguments& args) {
+  if (args.Length() != 1) {
+    const char* message = "chdir() takes one argument";
+    return ThrowException(String::New(message));
+  }
+  String::Utf8Value directory(args[0]);
+  if (*directory == NULL) {
+    const char* message = "os.chdir(): String conversion of argument failed.";
+    return ThrowException(String::New(message));
+  }
+  if (chdir(*directory) != 0) {
+    return ThrowException(String::New(strerror(errno)));
+  }
+  return v8::Undefined();
+}
+
+
 }  // namespace v8