Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 57005: Add os.chdir and os.setenv to d8. Move system() to os.system(). (Closed)

Created:
11 years, 8 months ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add os.chdir and os.setenv to d8. Move system() to os.system(). Protect os.chdir, os.setenv, os.system against string conversion failures. Add comment about the issue to include/v8.h. Committed: http://code.google.com/p/v8/source/detail?r=1644

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -8 lines) Patch
M include/v8.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/d8.h View 2 chunks +15 lines, -3 lines 0 comments Download
M src/d8.cc View 1 2 chunks +28 lines, -1 line 0 comments Download
M src/d8-posix.cc View 1 4 chunks +40 lines, -3 lines 0 comments Download
M src/d8-windows.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
11 years, 8 months ago (2009-03-30 08:56:21 UTC) #1
Mads Ager (chromium)
LGTM Consider adding explicit null checks before calling the library routines? http://codereview.chromium.org/57005/diff/1/3 File src/d8-posix.cc (right): ...
11 years, 8 months ago (2009-03-30 09:18:12 UTC) #2
Erik Corry
11 years, 8 months ago (2009-03-30 21:34:10 UTC) #3
Mads Ager (chromium)
11 years, 8 months ago (2009-03-31 05:54:56 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698