Remove inheritance of chromium flags

Remove inheritance of chromium flags

Committed: http://code.google.com/p/v8/source/detail?r=3936

[Evan Martin, 2010-02-04 17:27:09]

http://codereview.chromium.org/570022/diff/1/2
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/570022/diff/1/2#newcode53
tools/gyp/v8.gyp:53: 'target_defaults': {
I think you need to remove this extra layer of "target_defaults", since you're
already within a "target_defaults" block.

The "cflags" block below should be at the same nesting level as the "defines" in
the lower arm and ia32 blocks.

[Søren Thygesen Gjesse, 2010-02-05 10:32:14]

This seems to still build on both Windows and Linux.

I did not find a way to make the gyp generation match the flags we use in the
"official" SCons build for V8. However removing the inheritance of Chromium
flags seems only to affects warning flags.

There where several issues with matching the flags. First of all the -Werror and
-Wall seemed to always be removed by build/external_code.gypi. Another issue is
that we use -pedantic for our C++ files, but there is one C file in the
repository dtoa-config.c which should not have -pedantic. Also for this C file
the -Wall and -Werror is not suppressed.

So I gave up on matching the flags.

When compiling the x64 version on Linux the following flags from the SCons build
is not present

-Wall
-Werror
-W
-Wno-unused-parameter
-Wnon-virtual-dtor xx
-pedantic XX
-ansi

Whereas the following additional flags are passed:

-pthread
-D_FILE_OFFSET_BITS=64
-fno-strict-aliasing
-fno-ident
-fno-asynchronous-unwind-tables
-fno-threadsafe-statics
-fvisibility-inlines-hidden
-DCHROMIUM_BUILD
-DENABLE_GPU=1
-DNDEBUG
-DNVALGRIND

On Windows we will get the following additional defines

_CRT_SECURE_NO_DEPRECATE',
_CRT_NONSTDC_NO_WARNINGS',
_CRT_NONSTDC_NO_DEPRECATE',
_SCL_SECURE_NO_DEPRECATE',

And warning 4800 disabled and warnings not treated as errors.

[Mads Ager (chromium), 2010-02-05 11:23:56]

LGTM

[Evan Martin, 2010-02-23 16:05:13]

Did this ever land?  I saw a v8 merge happen and I eagerly checked for this line
but I didn't see it...

[Søren Thygesen Gjesse, 2010-02-24 08:23:31]

On 2010/02/23 16:05:13, Evan Martin wrote:
> Did this ever land?  I saw a v8 merge happen and I eagerly checked for this
line
> but I didn't see it...

I am sorry it did not. I am still a bit uneasy about the difference in flags
between the V8 SCons build and the build files generated from v8.gyp. But as
most of them are only related to relaxing warning/error levens and disabling
some optimizations I will go ahead and commit it.

[Evan Martin, 2010-02-24 11:39:03]

On 2010/02/24 08:23:31, Søren Gjesse wrote:
> On 2010/02/23 16:05:13, Evan Martin wrote:
> > Did this ever land?  I saw a v8 merge happen and I eagerly checked for this
> line
> > but I didn't see it...
> 
> I am sorry it did not. I am still a bit uneasy about the difference in flags
> between the V8 SCons build and the build files generated from v8.gyp. But as
> most of them are only related to relaxing warning/error levens and disabling
> some optimizations I will go ahead and commit it.

I expect that the v8 scons file and v8 gyp file generate different flags -- what
is probably better to check is whether v8 gyp file generates different settings
with chromium_code=1 vs chromium_code=0.

[Evan Martin, 2010-03-09 19:26:16]

It seems this still hasn't ended up in Chrome.  Do you need to explicitly merge
it to trunk for that to happen?

(Sorry to keep bugging you about this, but it's been over a month since the
change and I have a Chrome change blocked on this one...)