Switching media to gyp under windows.

Switching media to gyp under windows.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12761

[bradn, 2009-03-30 04:07:17]

Property changes on: media
___________________________________________________________________
Modified: svn:ignore
   - media.xcodeproj

   + media.xcodeproj
media.sln
media.vcproj
media_unittests.vcproj

[Mark Mentovai, 2009-03-30 04:11:07]

OK LG

http://codereview.chromium.org/57002/diff/1/6
File media/media.gyp (right):

http://codereview.chromium.org/57002/diff/1/6#newcode110
Line 110: 'filters/ffmpeg_audio_decoder.h',
No need to list .h files in sources!.

http://codereview.chromium.org/57002/diff/1/6#newcode114
Line 114: 'filters/ffmpeg_video_decoder.h',
Did you test on the Mac after building this list?  I see you adding
ffmpeg_demuxer.cc and ffmpeg_common.cc too, which were not previously built on
Mac.

[bradn, 2009-03-30 04:14:54]

http://codereview.chromium.org/57002/diff/1/6
File media/media.gyp (right):

http://codereview.chromium.org/57002/diff/1/6#newcode110
Line 110: 'filters/ffmpeg_audio_decoder.h',
On 2009/03/30 04:11:08, Mark Mentovai wrote:
> No need to list .h files in sources!.

Done.

http://codereview.chromium.org/57002/diff/1/6#newcode114
Line 114: 'filters/ffmpeg_video_decoder.h',
On 2009/03/30 04:11:08, Mark Mentovai wrote:
> Did you test on the Mac after building this list?  I see you adding
> ffmpeg_demuxer.cc and ffmpeg_common.cc too, which were not previously built on
> Mac.
They build, but the tests don't. Should I exclude them?

[Nicolas Sylvain, 2009-03-30 15:27:38]

lgtm