Policy: Re-enabled plugin still disabled

chrome/browser/chromeos/gview_request_interceptor_unittest.cc

Index: chrome/browser/chromeos/gview_request_interceptor_unittest.cc
diff --git a/chrome/browser/chromeos/gview_request_interceptor_unittest.cc b/chrome/browser/chromeos/gview_request_interceptor_unittest.cc
index 63f76cc904ed90fe876e7e81df0b476aec67a4a4..dfd70b7ed0571c8c89e28b4c63c0933390c0b618 100644
--- a/chrome/browser/chromeos/gview_request_interceptor_unittest.cc
+++ b/chrome/browser/chromeos/gview_request_interceptor_unittest.cc
@@ -66,7 +66,11 @@ class GViewRequestInterceptorTest : public testing::Test {
   }
 
   void RegisterPDFPlugin() {
-    webkit::npapi::PluginList::Singleton()->RegisterInternalPlugin(pdf_path_);
+    webkit::npapi::PluginVersionInfo pdf_plugin;
+    memset(&pdf_plugin.entry_points, 0, sizeof(pdf_plugin.entry_points));
+    pdf_plugin.path = pdf_path_;
+    pdf_plugin.product_name = ASCIIToWide("PDF Plugin");

[jam, 2011/01/19 20:22:09]

is this code still needed, i.e. adding a description when one doesn't exist to
make it different from placeholder plugins?

[pastarmovj, 2011/01/19 23:39:17]

Actually yes. This plugin has description in it's original PluginList
registrastion. All internal plugins get registered through the
RegisterInternalPlugin function that has 5 params - path, name, desc,
mime-types, entry points. Actually this one RegisterInternalPlugin function that
takes only path is used only in this single unit test suite. That is also why I
removed it from PluginLists. It was not used anywhere else.

[jam, 2011/01/20 00:24:25]

oops, I didn't notice that this is a test file, in that case, ignore my comment.
 I always favor making test code more verbose/ugly over doing the same to
shipping code :)

+    webkit::npapi::PluginList::Singleton()->RegisterInternalPlugin(pdf_plugin);
     webkit::npapi::PluginList::Singleton()->RefreshPlugins();
   }
 
@@ -93,7 +97,7 @@ class GViewRequestInterceptorTest : public testing::Test {
           pdf_path_, &info);
     }
     EXPECT_EQ(want_loaded, is_loaded);
-    *out_is_enabled = info.enabled;
+    *out_is_enabled = webkit::npapi::IsPluginEnabled(info);
   }
 
  protected: