Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: webkit/plugins/npapi/plugin_list_win.cc

Issue 5699005: Policy: Re-enabled plugin still disabled (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed unit tests. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/npapi/plugin_list_win.cc
diff --git a/webkit/plugins/npapi/plugin_list_win.cc b/webkit/plugins/npapi/plugin_list_win.cc
index d7f13ef954c225f01e6cadd812e0fb24ff187214..b3b7eb48b3301d1ceacf97a7ecee6ae4ed4f6842 100644
--- a/webkit/plugins/npapi/plugin_list_win.cc
+++ b/webkit/plugins/npapi/plugin_list_win.cc
@@ -272,9 +272,8 @@ void PluginList::LoadPluginsFromDir(const FilePath &path,
FindClose(find_handle);
}
-void PluginList::LoadPluginsFromRegistry(
- std::vector<WebPluginInfo>* plugins,
- std::set<FilePath>* visited_plugins) {
+void PluginList::LoadPluginsFromRegistry(std::vector<WebPluginInfo>* plugins,
+ std::set<FilePath>* visited_plugins) {
std::set<FilePath> plugin_dirs;
GetPluginsInRegistryDirectory(
@@ -337,13 +336,13 @@ bool PluginList::ShouldLoadPlugin(const WebPluginInfo& info,
for (size_t i = 0; i < plugins->size(); ++i) {
std::wstring plugin1 =
- StringToLowerASCII((*plugins)[i].path.BaseName().ToWStringHack());
+ StringToLowerASCII(plugins->at(i).path.BaseName().ToWStringHack());
std::wstring plugin2 =
StringToLowerASCII(info.path.BaseName().ToWStringHack());
- if ((plugin1 == plugin2 && HaveSharedMimeType((*plugins)[i], info)) ||
+ if ((plugin1 == plugin2 && HaveSharedMimeType(plugins->at(i), info)) ||
(plugin1 == kJavaDeploy1 && plugin2 == kJavaDeploy2) ||
(plugin1 == kJavaDeploy2 && plugin2 == kJavaDeploy1)) {
- if (!IsNewerVersion((*plugins)[i].version, info.version))
+ if (!IsNewerVersion(plugins->at(i).version, info.version))
return false; // We have loaded a plugin whose version is newer.
plugins->erase(plugins->begin() + i);
@@ -394,14 +393,14 @@ bool PluginList::ShouldLoadPlugin(const WebPluginInfo& info,
return false;
for (size_t i = 0; i < plugins->size(); ++i) {
- if ((*plugins)[i].path.BaseName().value() == kOldWMPPlugin) {
+ if (plugins->at(i).path.BaseName().value() == kOldWMPPlugin) {
plugins->erase(plugins->begin() + i);
break;
}
}
} else if (filename == kOldWMPPlugin) {
for (size_t i = 0; i < plugins->size(); ++i) {
- if ((*plugins)[i].path.BaseName().value() == kNewWMPPlugin)
+ if (plugins->at(i).path.BaseName().value() == kNewWMPPlugin)
return false;
}
}

Powered by Google App Engine
This is Rietveld 408576698