Policy: Re-enabled plugin still disabled

webkit/glue/plugins/plugin_list_mac.mm

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/plugins/plugin_list.h"
 
 #import <Foundation/Foundation.h>
 
 #include "base/file_util.h"
 #include "base/mac_util.h"
@@ skipping 45 matching lines @@
 
 void PluginList::GetPluginDirectories(std::vector<FilePath>* plugin_dirs) {
   // Load from the user's area
   GetPluginCommonDirectory(plugin_dirs, true);
 
   // Load from the machine-wide area
   GetPluginCommonDirectory(plugin_dirs, false);
 }
 
 void PluginList::LoadPluginsFromDir(const FilePath &path,
-                                    std::vector<WebPluginInfo>* plugins,
                                     std::set<FilePath>* visited_plugins) {
   file_util::FileEnumerator enumerator(path,
                                        false, // not recursive
                                        file_util::FileEnumerator::DIRECTORIES);
   for (FilePath path = enumerator.Next(); !path.value().empty();
        path = enumerator.Next()) {
-    LoadPlugin(path, plugins);
+    LoadPlugin(path);
     visited_plugins->insert(path);
   }
 }
 
-bool PluginList::ShouldLoadPlugin(const WebPluginInfo& info,
-                                  std::vector<WebPluginInfo>* plugins) {
+bool PluginList::ShouldLoadPlugin(const WebPluginInfo& info) {
   if (IsBlacklistedPlugin(info))
     return false;
 
   // Flip4Mac has a reproducible hang during a synchronous call from the render
   // with certain content types (as well as a common crash). Disable by default
   // to minimize those issues, but don't blacklist it so that users can choose
   // to enable it.
   if (StartsWith(info.name, ASCIIToUTF16("Flip4Mac Windows Media Plugin"),
                  false))
-    DisablePlugin(info.path);
+    DisablePlugin(info.path, true);
 
   // Hierarchy check
   // (we're loading plugins hierarchically from Library folders, so plugins we
   //  encounter earlier must override plugins we encounter later)
-  for (size_t i = 0; i < plugins->size(); ++i) {
-    if ((*plugins)[i].path.BaseName() == info.path.BaseName()) {
-      return false;  // We already have a loaded plugin higher in the hierarchy.
+  std::vector<WebPluginInfo*> new_plugins;
+  for (PluginGroup::PluginMap::iterator it = plugin_groups_.begin();
+       it != plugin_groups_.end(); ++it) {
+    std::vector<WebPluginInfo>& group_plugins = it->second->GetPlugins();
+    for (std::vector<WebPluginInfo>::iterator itp = group_plugins.begin();
+         itp != group_plugins.end();
+         ++itp) {
+      if (itp->path.BaseName() == info.path.BaseName()) {
+        // We already have a loaded plugin higher in the hierarchy.
+        return false;
+      }
     }
   }
 
   return true;
 }
 
 } // namespace NPAPI