Policy: Re-enabled plugin still disabled

chrome/browser/plugin_service.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugin_service.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/path_service.h"
@@ skipping 285 matching lines @@
 }
 
 void PluginService::GetAllowedPluginForOpenChannelToPlugin(
     const GURL& url,
     const std::string& mime_type,
     PluginProcessHost::Client* client) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   webkit::npapi::WebPluginInfo info;
   bool found = GetFirstAllowedPluginInfo(url, mime_type, &info, NULL);
   FilePath plugin_path;
-  if (found && info.enabled)
+  if (found && webkit::npapi::IsPluginEnabled(info))
     plugin_path = FilePath(info.path);
 
   // Now we jump back to the IO thread to finish opening the channel.
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       NewRunnableMethod(
           this, &PluginService::FinishOpenChannelToPlugin,
           plugin_path, client));
 }
 
@@ skipping 107 matching lines @@
 
 #if defined(OS_MACOSX)
     case NotificationType::APP_ACTIVATED: {
       BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                               NewRunnableFunction(&NotifyPluginsOfActivation));
       break;
     }
 #endif
 
     case NotificationType::PLUGIN_ENABLE_STATUS_CHANGED: {
+      webkit::npapi::PluginList::Singleton()->RefreshPlugins();

[jam, 2011/01/19 20:22:09]

I think we want to avoid reloading the plugins from disk when the user
enables/disables plugins, since it's an expensive operation.

[pastarmovj, 2011/01/19 23:39:17]

If we don't do that here policy changes during the runtime won't take effect
until next restart. I don't think that is so bad especially because we only mark
plugins for refresh here we don't enforce it.
And the UI anyway will refresh the plugins always after the user actually
interacts with it.

[jam, 2011/01/20 00:24:25]

I see, I didn't know that the UI always marks it for refresh.  It would be nice
to avoid that, since no need to do all that unnecessary disk access.  But since
it should be rare, ok for now although I'd love to see that changed in the
future :)

       PurgePluginListCache(false);
       break;
     }
     default:
       NOTREACHED();
   }
 }
 
 bool PluginService::PrivatePluginAllowedForURL(const FilePath& plugin_path,
                                                const GURL& url) {
@@ skipping 37 matching lines @@
 #if defined(OS_LINUX)
 // static
 void PluginService::RegisterFilePathWatcher(
     FilePathWatcher *watcher,
     const FilePath& path,
     FilePathWatcher::Delegate* delegate) {
   bool result = watcher->Watch(path, delegate);
   DCHECK(result);
 }
 #endif