Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6275)

Unified Diff: chrome/browser/resources/shared/js/cr/ui/list.js

Issue 5699004: [tabbed options] more work on content settings exceptions lists (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/shared/js/cr/ui/list.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/list.js b/chrome/browser/resources/shared/js/cr/ui/list.js
index 33a984ebf5e87e3565666798f8bf9ca90a2343d6..c2e032dd5bc8c0e9d046b083e1e4fd4304e54feb 100644
--- a/chrome/browser/resources/shared/js/cr/ui/list.js
+++ b/chrome/browser/resources/shared/js/cr/ui/list.js
@@ -223,12 +223,12 @@ cr.define('cr.ui', function() {
},
/**
- * The HTML elements representing the items. This is just all the element
+ * The HTML elements representing the items. This is just all the <li>
arv (Not doing code reviews) 2010/12/15 02:47:27 I don't think <li> is correct here. Is there any o
Evan Stade 2010/12/15 04:12:38 good point
* children but subclasses may override this to filter out certain elements.
* @type {HTMLCollection}
*/
get items() {
arv (Not doing code reviews) 2010/12/15 02:47:27 Yeah, this cannot have been used before since it w
- return this.children;
+ return this.querySelectorAll('li');
arv (Not doing code reviews) 2010/12/15 02:47:27 This also gives nested elements. I think we need t
},
batchCount_: 0,

Powered by Google App Engine
This is Rietveld 408576698