chrome/browser/resources/options/content_settings.js - Issue 5699004: [tabbed options] more work on content settings exceptions lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/content_settings.js

Issue 5699004: [tabbed options] more work on content settings exceptions lists (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: subclass Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/dom_ui/options/content_settings_handler.cc ('k') | chrome/browser/resources/options/content_settings_exceptions_area.css » ('j') | chrome/browser/resources/options/content_settings_exceptions_area.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/content_settings.js

diff --git a/chrome/browser/resources/options/content_settings.js b/chrome/browser/resources/options/content_settings.js

index 96c22793830b5357c53e35a2fc1a300c888b8686..efc85e84d277e7959fdac60ca600500d593affa4 100644

--- a/chrome/browser/resources/options/content_settings.js

+++ b/chrome/browser/resources/options/content_settings.js

@@ -94,7 +94,7 @@ cr.define('options', function() {

document.querySelector('div[contentType=' + type + ']' +

' list[mode=normal]');

- exceptionsList.clear();

+ exceptionsList.reset();

for (var i = 0; i < list.length; i++) {

exceptionsList.addException(list[i]);

}

@@ -108,7 +108,7 @@ cr.define('options', function() {

exceptionsList.parentNode.classList.remove('hidden');

- exceptionsList.clear();

+ exceptionsList.reset();

for (var i = 0; i < list.length; i++) {

exceptionsList.addException(list[i]);

}

@@ -129,7 +129,7 @@ cr.define('options', function() {

var otrLists = document.querySelectorAll('list[mode=otr]');

for (var i = 0; i < otrLists.length; i++) {

- otrLists[i].clear();

+ otrLists[i].reset();

otrLists[i].parentNode.classList.add('hidden');

}

};

@@ -154,8 +154,8 @@ cr.define('options', function() {

ContentSettings.patternValidityCheckComplete =

function(type, mode, pattern, valid) {

var exceptionsList =

- document.querySelector('div[contentType=' + type + '][mode=' + mode +

- '] list');

+ document.querySelector('div[contentType=' + type + '] ' +

+ 'list[mode=' + mode + ']');

exceptionsList.patternValidityCheckComplete(pattern, valid);

};