Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/resources/options/content_settings.js

Issue 5699004: [tabbed options] more work on content settings exceptions lists (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: subclass Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/content_settings.js
diff --git a/chrome/browser/resources/options/content_settings.js b/chrome/browser/resources/options/content_settings.js
index 96c22793830b5357c53e35a2fc1a300c888b8686..efc85e84d277e7959fdac60ca600500d593affa4 100644
--- a/chrome/browser/resources/options/content_settings.js
+++ b/chrome/browser/resources/options/content_settings.js
@@ -94,7 +94,7 @@ cr.define('options', function() {
document.querySelector('div[contentType=' + type + ']' +
' list[mode=normal]');
- exceptionsList.clear();
+ exceptionsList.reset();
for (var i = 0; i < list.length; i++) {
exceptionsList.addException(list[i]);
}
@@ -108,7 +108,7 @@ cr.define('options', function() {
exceptionsList.parentNode.classList.remove('hidden');
- exceptionsList.clear();
+ exceptionsList.reset();
for (var i = 0; i < list.length; i++) {
exceptionsList.addException(list[i]);
}
@@ -129,7 +129,7 @@ cr.define('options', function() {
var otrLists = document.querySelectorAll('list[mode=otr]');
for (var i = 0; i < otrLists.length; i++) {
- otrLists[i].clear();
+ otrLists[i].reset();
otrLists[i].parentNode.classList.add('hidden');
}
};
@@ -154,8 +154,8 @@ cr.define('options', function() {
ContentSettings.patternValidityCheckComplete =
function(type, mode, pattern, valid) {
var exceptionsList =
- document.querySelector('div[contentType=' + type + '][mode=' + mode +
- '] list');
+ document.querySelector('div[contentType=' + type + '] ' +
+ 'list[mode=' + mode + ']');
exceptionsList.patternValidityCheckComplete(pattern, valid);
};

Powered by Google App Engine
This is Rietveld 408576698