[tabbed options] more work on content settings exceptions lists

chrome/browser/resources/shared/js/cr/ui/list.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: listselectionmodel.js
 
 /**
  * @fileoverview This implements a list control.
  */
 
@@ skipping 205 matching lines @@
       var dataModel = this.dataModel;
       if (dataModel) {
         return indexes.map(function(i) {
           return dataModel.item(i);
         });
       }
       return [];
     },
 
     /**
-     * The HTML elements representing the items. This is just all the element
+     * The HTML elements representing the items. This is just all the list item
      * children but subclasses may override this to filter out certain elements.
      * @type {HTMLCollection}
      */
     get items() {
-      return this.children;
+      var listItems = [];
+      var children = this.children;
+      for (var i = 0; i < children.length; i++) {
+        var classList = children[i].classList;
+        if (classList && !classList.contains('spacer'))

[arv (Not doing code reviews), 2010/12/15 04:15:28]

classList should never be falsey

+          listItems.push(children[i]);
+      }
+      return listItems;

[arv (Not doing code reviews), 2010/12/15 04:15:28]

How about:

return Array.prototype.filter.call(this.children, function(child) {
  return child.classList.contains('spacer');
});

     },
 
     batchCount_: 0,
 
     /**
      * When making a lot of updates to the list, the code could be wrapped in
      * the startBatchUpdates and finishBatchUpdates to increase performance. Be
      * sure that the code will not return without calling endBatchUpdates or the
      * list will not be correctly updated.
      */
@@ skipping 328 matching lines @@
       }
     }
   };
 
   cr.defineProperty(List, 'disabled', cr.PropertyKind.BOOL_ATTR);
 
   return {
     List: List
   }
 });