[tabbed options] more work on content settings exceptions lists

chrome/browser/resources/shared/js/cr/ui/list.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: listselectionmodel.js
 
 /**
  * @fileoverview This implements a list control.
  */
 
@@ skipping 205 matching lines @@
       var dataModel = this.dataModel;
       if (dataModel) {
         return indexes.map(function(i) {
           return dataModel.item(i);
         });
       }
       return [];
     },
 
     /**
-     * The HTML elements representing the items. This is just all the element
+     * The HTML elements representing the items. This is just all the <li>

[arv (Not doing code reviews), 2010/12/15 02:47:27]

I don't think <li> is correct here. Is there any other place that this is hard
coded? I think instances can use any tag name they want

[Evan Stade, 2010/12/15 04:12:38]

good point

      * children but subclasses may override this to filter out certain elements.
      * @type {HTMLCollection}
      */
     get items() {

[arv (Not doing code reviews), 2010/12/15 02:47:27]

Yeah, this cannot have been used before since it was clearly broken.

-      return this.children;
+      return this.querySelectorAll('li');

[arv (Not doing code reviews), 2010/12/15 02:47:27]

This also gives nested elements. I think we need to use children and filter out
the spacers.

     },
 
     batchCount_: 0,
 
     /**
      * When making a lot of updates to the list, the code could be wrapped in
      * the startBatchUpdates and finishBatchUpdates to increase performance. Be
      * sure that the code will not return without calling endBatchUpdates or the
      * list will not be correctly updated.
      */
@@ skipping 328 matching lines @@
       }
     }
   };
 
   cr.defineProperty(List, 'disabled', cr.PropertyKind.BOOL_ATTR);
 
   return {
     List: List
   }
 });