Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 5698008: Switch a bunch of remaining filters to derive from BrowserMessageFilters so t... (Closed)

Created:
10 years ago by jam
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, kinuko, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Switch a bunch of remaining filters to derive from BrowserMessageFilters so that ResourceMessageFilter doesn't have to know about them and vice versa. A bunch of small cleanup in the process. I've added new message files for classes that want their messages dispatched on threads other than the IO. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69008

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -1543 lines) Patch
D chrome/browser/device_orientation/dispatcher_host.h View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/device_orientation/dispatcher_host.cc View 1 chunk +0 lines, -112 lines 0 comments Download
A + chrome/browser/device_orientation/message_filter.h View 2 chunks +12 lines, -14 lines 0 comments Download
A + chrome/browser/device_orientation/message_filter.cc View 5 chunks +22 lines, -28 lines 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.h View 3 chunks +9 lines, -21 lines 0 comments Download
M chrome/browser/file_system/file_system_dispatcher_host.cc View 4 chunks +7 lines, -34 lines 0 comments Download
D chrome/browser/mime_registry_dispatcher.h View 1 chunk +0 lines, -37 lines 0 comments Download
D chrome/browser/mime_registry_dispatcher.cc View 1 chunk +0 lines, -96 lines 0 comments Download
A + chrome/browser/mime_registry_message_filter.h View 1 chunk +15 lines, -21 lines 0 comments Download
A + chrome/browser/mime_registry_message_filter.cc View 1 chunk +28 lines, -73 lines 0 comments Download
D chrome/browser/renderer_host/blob_dispatcher_host.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/renderer_host/blob_dispatcher_host.cc View 1 chunk +0 lines, -88 lines 0 comments Download
A + chrome/browser/renderer_host/blob_message_filter.h View 3 chunks +13 lines, -11 lines 0 comments Download
A + chrome/browser/renderer_host/blob_message_filter.cc View 5 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 3 chunks +16 lines, -0 lines 0 comments Download
D chrome/browser/renderer_host/file_utilities_dispatcher_host.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/renderer_host/file_utilities_dispatcher_host.cc View 1 chunk +0 lines, -199 lines 0 comments Download
A + chrome/browser/renderer_host/file_utilities_message_filter.h View 2 chunks +19 lines, -34 lines 0 comments Download
A + chrome/browser/renderer_host/file_utilities_message_filter.cc View 2 chunks +39 lines, -132 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 4 chunks +0 lines, -37 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 7 chunks +2 lines, -48 lines 0 comments Download
D chrome/browser/search_engines/search_provider_install_state_dispatcher_host.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/search_engines/search_provider_install_state_dispatcher_host.cc View 1 chunk +0 lines, -123 lines 0 comments Download
A + chrome/browser/search_engines/search_provider_install_state_message_filter.h View 2 chunks +13 lines, -27 lines 0 comments Download
A + chrome/browser/search_engines/search_provider_install_state_message_filter.cc View 3 chunks +14 lines, -24 lines 0 comments Download
M chrome/browser/speech/speech_input_dispatcher_host.h View 4 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/speech/speech_input_dispatcher_host.cc View 9 chunks +16 lines, -34 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/worker_host/worker_process_host.cc View 6 chunks +9 lines, -31 lines 0 comments Download
M chrome/chrome_browser.gypi View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/common/file_utilities_messages.h View 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/common/file_utilities_messages.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/common/mime_registry_messages.h View 1 chunk +28 lines, -0 lines 0 comments Download
A chrome/common/mime_registry_messages.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +0 lines, -28 lines 0 comments Download
M chrome/renderer/renderer_webkitclient_impl.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M chrome/worker/worker_webkitclient_impl.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M ipc/ipc_message_macros.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
10 years ago (2010-12-13 07:14:31 UTC) #1
brettw
10 years ago (2010-12-13 16:26:00 UTC) #2
This is super, LGTM

Powered by Google App Engine
This is Rietveld 408576698