Fix Instant suggest issues in Linux Views port.

Fix Instant suggest issues in Linux Views port.

This CL changes Linux Views port to use the same code of Linux Gtk port
for displaying Instant suggest rather than using the code of Windows
port. The reason is: GtkTextView used by AutocompleteEditViewGtk can't
work with SuggestedTextView very well.

This CL also fixes some issues in AutocompleteEditViewGtk related to RTL
text.

BUG=66167
BUG=66151
TEST=See issue report.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69017

[Evan Stade, 2010-12-11 00:13:25]

lgtm, although I wonder if there's a way to reduce the ifdefs in
location_bar_view

http://codereview.chromium.org/5698006/diff/1/chrome/browser/autocomplete/aut...
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/5698006/diff/1/chrome/browser/autocomplete/aut...
chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:451:
horizontal_border_size;
indentation is weird here

http://codereview.chromium.org/5698006/diff/1/chrome/browser/autocomplete/aut...
chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:891: // TODO(suzhe):
fix me.
?

http://codereview.chromium.org/5698006/diff/1/chrome/browser/autocomplete/aut...
chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:1214: gint
count_towards_end = (content_dir == PANGO_DIRECTION_RTL ? -1 : 1);
no ()

http://codereview.chromium.org/5698006/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/5698006/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:4030: # Right now, we don't use SuggestedTextView for
Linux Views port.
can you just remove these lines instead?

[sky, 2010-12-11 00:20:38]

The current thinking is that that suggestions for misspelled words will be shown
to the right of the text after an arrow image. For example, if you type 'briten'
the suggestion is 'britney spears' and we'll show:

briten<-britney spears

where <- is an image of an arrow. If we have the edit render the suggested text,
will it be able to handle an embedded image?

[James Su, 2010-12-11 00:32:32]

CL Updated.

http://codereview.chromium.org/5698006/diff/1/chrome/browser/autocomplete/aut...
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/5698006/diff/1/chrome/browser/autocomplete/aut...
chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:891: // TODO(suzhe):
fix me.
On 2010/12/11 00:13:25, Evan Stade wrote:
> ?

Done.

http://codereview.chromium.org/5698006/diff/1/chrome/browser/autocomplete/aut...
chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:1214: gint
count_towards_end = (content_dir == PANGO_DIRECTION_RTL ? -1 : 1);
On 2010/12/11 00:13:25, Evan Stade wrote:
> no ()

Done.

[James Su, 2010-12-11 00:33:43]

On 2010/12/11 00:20:38, sky wrote:
> The current thinking is that that suggestions for misspelled words will be
shown
> to the right of the text after an arrow image. For example, if you type
'briten'
> the suggestion is 'britney spears' and we'll show:
> 
> briten<-britney spears
> 
> where <- is an image of an arrow. If we have the edit render the suggested
text,
> will it be able to handle an embedded image?
Yes, we can put any widget into GtkTextView.

[sky, 2010-12-13 17:27:33]

LGTM

http://codereview.chromium.org/5698006/diff/6001/chrome/browser/ui/views/loca...
File chrome/browser/ui/views/location_bar/location_bar_view.h (right):

http://codereview.chromium.org/5698006/diff/6001/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_bar_view.h:45: #if defined(OS_WIN)
Move conditional forward declarations after non-conditional forward
declarations.

http://codereview.chromium.org/5698006/diff/6001/chrome/browser/ui/views/loca...
chrome/browser/ui/views/location_bar/location_bar_view.h:323: bool
HasValidSuggestText();
Move this to around line 315 so that you have one less ifdef