chrome/browser/download/download_shelf.cc - Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf.cc

Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved background page badge fix to another CL. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_shelf.cc

diff --git a/chrome/browser/download/download_shelf.cc b/chrome/browser/download/download_shelf.cc

index 8d11e9ad4436c0c7fd092ac8100a2c19d5388f3d..e43be8dbfeefd72829869f3a9e320ac03b71620f 100644

--- a/chrome/browser/download/download_shelf.cc

+++ b/chrome/browser/download/download_shelf.cc

@@ -110,7 +110,7 @@ bool DownloadShelfContextMenu::GetAcceleratorForCommandId(

return false;

}

-bool DownloadShelfContextMenu::IsLabelForCommandIdDynamic(

+bool DownloadShelfContextMenu::IsItemForCommandIdDynamic(

int command_id) const {

return command_id == TOGGLE_PAUSE;

}