Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2454)

Unified Diff: app/menus/menu_model.h

Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved background page badge fix to another CL. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: app/menus/menu_model.h
diff --git a/app/menus/menu_model.h b/app/menus/menu_model.h
index 8247f60af0c461d6b551957d766b1efe663d430b..76710788a707446575a06e4a5ec82e75541528f5 100644
--- a/app/menus/menu_model.h
+++ b/app/menus/menu_model.h
@@ -63,10 +63,11 @@ class MenuModel {
// Returns the label of the item at the specified index.
virtual string16 GetLabelAt(int index) const = 0;
- // Returns true if the label at the specified index can change over the course
- // of the menu's lifetime. If this function returns true, the label of the
- // menu item will be updated each time the menu is shown.
- virtual bool IsLabelDynamicAt(int index) const = 0;
+ // Returns true if the menu item (label/icon) at the specified index can
+ // change over the course of the menu's lifetime. If this function returns
+ // true, the label and icon of the menu item will be updated each time the
+ // menu is shown.
+ virtual bool IsItemDynamicAt(int index) const = 0;
// Returns the font use for the label at the specified index.
// If NULL, then use default font.

Powered by Google App Engine
This is Rietveld 408576698