chrome/browser/ui/views/frame/browser_view.cc - Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index b970b16346b74522bc061e458f3476e3779e39ab..f080d7c07a1409c8e7e114070c15cbce4a154f70 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1525,7 +1525,7 @@ bool BrowserView::GetAcceleratorForCommandId(int command_id,

return toolbar_->GetAcceleratorForCommandId(command_id, accelerator);

}

-bool BrowserView::IsLabelForCommandIdDynamic(int command_id) const {

+bool BrowserView::IsItemForCommandIdDynamic(int command_id) const {

return command_id == IDC_RESTORE_TAB;

}