chrome/browser/ui/toolbar/wrench_menu_model.h - Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.h

Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/wrench_menu_model.h

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.h b/chrome/browser/ui/toolbar/wrench_menu_model.h

index e984a4b955be8fdf882eda406787e329c97bf1fa..2690ea9bab7e57b91aa1517fe0063910b7381dc8 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model.h

+++ b/chrome/browser/ui/toolbar/wrench_menu_model.h

@@ -82,8 +82,9 @@ class WrenchMenuModel : public menus::SimpleMenuModel,

virtual bool DoesCommandIdDismissMenu(int command_id) const;

// Overridden for both ButtonMenuItemModel::Delegate and SimpleMenuModel:

- virtual bool IsLabelForCommandIdDynamic(int command_id) const;

+ virtual bool IsItemForCommandIdDynamic(int command_id) const;

virtual string16 GetLabelForCommandId(int command_id) const;

+ virtual bool GetIconForCommandId(int command_id, SkBitmap* icon) const;

virtual void ExecuteCommand(int command_id);

virtual bool IsCommandIdChecked(int command_id) const;

virtual bool IsCommandIdEnabled(int command_id) const;