chrome/browser/notifications/notification_options_menu_model.cc - Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_options_menu_model.cc

Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_options_menu_model.cc

diff --git a/chrome/browser/notifications/notification_options_menu_model.cc b/chrome/browser/notifications/notification_options_menu_model.cc

index 126e5ff8168205f354227741a40174463063dca5..1e397f89f251b49707ab931091d1fd1d734cac61 100644

--- a/chrome/browser/notifications/notification_options_menu_model.cc

+++ b/chrome/browser/notifications/notification_options_menu_model.cc

@@ -54,7 +54,7 @@ NotificationOptionsMenuModel::NotificationOptionsMenuModel(Balloon* balloon)

NotificationOptionsMenuModel::~NotificationOptionsMenuModel() {

}

-bool NotificationOptionsMenuModel::IsLabelForCommandIdDynamic(int command_id)

+bool NotificationOptionsMenuModel::IsItemForCommandIdDynamic(int command_id)

const {

return command_id == kTogglePermissionCommand ||

command_id == kToggleExtensionCommand;