chrome/browser/download/download_shelf.h - Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf.h

Issue 5697005: Change SimpleMenuModel on OSX to support dynamic icons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update after merge Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_shelf.h

diff --git a/chrome/browser/download/download_shelf.h b/chrome/browser/download/download_shelf.h

index b85123cdb89b941895a031df1b0dd7ad9d36ee3d..ab565fa7043304442339bb503adddeb55f703402 100644

--- a/chrome/browser/download/download_shelf.h

+++ b/chrome/browser/download/download_shelf.h

@@ -73,7 +73,7 @@ class DownloadShelfContextMenu : public menus::SimpleMenuModel::Delegate {

virtual void ExecuteCommand(int command_id);

virtual bool GetAcceleratorForCommandId(int command_id,

menus::Accelerator* accelerator);

- virtual bool IsLabelForCommandIdDynamic(int command_id) const;

+ virtual bool IsItemForCommandIdDynamic(int command_id) const;

virtual string16 GetLabelForCommandId(int command_id) const;

// A model to control the cancel behavior.