Fixes bug in instant where we wouldn't initially tell the page the

chrome/browser/instant/instant_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_edit_view.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/browser_window.h"
@@ skipping 65 matching lines @@
   void SetupPreview() {
     preview_ = browser()->instant()->GetPreviewContents()->tab_contents();
     ASSERT_TRUE(preview_);
     ui_test_utils::WaitForNavigation(&preview_->controller());
 
     // Verify the initial setup of the search box.
     ASSERT_TRUE(browser()->instant());
     EXPECT_TRUE(browser()->instant()->IsShowingInstant());
     EXPECT_FALSE(browser()->instant()->is_active());
 
-    // When the page loads, the initial searchBox values are set and no events
-    // have been called.
+    // When the page loads, the initial searchBox values are set and only a
+    // resize will have been sent.
     EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
         true, "window.chrome.sv", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
         0, "window.onsubmitcalls", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
         0, "window.oncancelcalls", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
         0, "window.onchangecalls", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
-        0, "window.onresizecalls", preview_));
+        1, "window.onresizecalls", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckStringValueFromJavascript(
         "a", "window.chrome.searchBox.value", preview_));
     EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
         false, "window.chrome.searchBox.verbatim", preview_));
   }
 
   void SetLocationBarText(const std::wstring& text) {
     ASSERT_NO_FATAL_FAILURE(FindLocationBar());
     location_bar_->location_entry()->SetUserText(text);
     ui_test_utils::WaitForNotification(
@@ skipping 127 matching lines @@
   // Instant should not be current (it's still loading).
   EXPECT_FALSE(browser()->instant()->IsCurrent());
 
   // When the response comes back that the page doesn't support instant the tab
   // should be closed.
   ui_test_utils::WaitForNotification(NotificationType::TAB_CLOSED);
   EXPECT_FALSE(browser()->instant()->IsShowingInstant());
   EXPECT_FALSE(browser()->instant()->is_active());
 }
 
+// Verifies the page was told a non-zero height.
+IN_PROC_BROWSER_TEST_F(InstantTest, ValidHeight) {
+  ASSERT_TRUE(test_server()->Start());
+  ASSERT_NO_FATAL_FAILURE(SetupInstantProvider("old_api.html"));
+  ASSERT_NO_FATAL_FAILURE(SetLocationBarText(L"a"));
+  // The preview should be active.
+  ASSERT_TRUE(browser()->instant()->is_active());
+  // And the height should be valid.
+  ASSERT_NO_FATAL_FAILURE(
+      CheckBoolValueFromJavascript(
+          true, "window.validHeight",

[tonyg, 2010/12/11 00:44:17]

What do you think about replacing this with a test for the new API (ie.
window.searchBox.{x,y,width,height}) or if you want this one add a new one along
side. If you do that, there's a TODO on line 168 that can be killed.

+          browser()->instant()->GetPreviewContents()->tab_contents()));
+}
+
 // Verify that the onsubmit event is dispatched upon pressing enter.
 // TODO(sky): Disabled, http://crbug.com/62940.
 IN_PROC_BROWSER_TEST_F(InstantTest, DISABLED_OnSubmitEvent) {
   ASSERT_TRUE(test_server()->Start());
   ASSERT_NO_FATAL_FAILURE(SetupInstantProvider("search.html"));
   ASSERT_NO_FATAL_FAILURE(SetupLocationBar());
   ASSERT_NO_FATAL_FAILURE(SetupPreview());
 
   ASSERT_NO_FATAL_FAILURE(SetLocationBarText(L"abc"));
   ASSERT_NO_FATAL_FAILURE(SendKey(app::VKEY_RETURN));
@@ skipping 39 matching lines @@
   // Check that the value is reflected and oncancel is called.
   EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
       true, "window.chrome.sv", contents));
   EXPECT_NO_FATAL_FAILURE(CheckStringValueFromJavascript(
       "abc", "window.chrome.searchBox.value", contents));
   EXPECT_NO_FATAL_FAILURE(CheckBoolValueFromJavascript(
       false, "window.chrome.searchBox.verbatim", contents));
   EXPECT_NO_FATAL_FAILURE(CheckIntValueFromJavascript(
       1, "window.oncancelcalls", contents));
 }