Issue 5695002: IndexedDB: Numeric keys are floating point.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5695002: IndexedDB: Numeric keys are floating point. (Closed)

Created:
10 years ago by hans

Modified:
9 years, 5 months ago

Reviewers:
jorlow

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

IndexedDB: Numeric keys are floating point. Depends on WebKit r73697. BUG=65619 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68851

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	chrome/common/indexed_db_key.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/indexed_db_key.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/indexed_db_param_traits.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/indexeddb/cursor_test.js	View	3 chunks	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jorlow

LGTM http://codereview.chromium.org/5695002/diff/1/chrome/test/data/indexeddb/cursor_test.js File chrome/test/data/indexeddb/cursor_test.js (right): http://codereview.chromium.org/5695002/diff/1/chrome/test/data/indexeddb/cursor_test.js#newcode40 chrome/test/data/indexeddb/cursor_test.js:40: var keyRange = webkitIDBKeyRange.lowerBound(3.12); Is 3.12 intentional?

10 years ago (2010-12-09 17:40:18 UTC) #2

hans

10 years ago (2010-12-09 17:42:29 UTC) #3

http://codereview.chromium.org/5695002/diff/1/chrome/test/data/indexeddb/curs...
File chrome/test/data/indexeddb/cursor_test.js (right):

http://codereview.chromium.org/5695002/diff/1/chrome/test/data/indexeddb/curs...
chrome/test/data/indexeddb/cursor_test.js:40: var keyRange =
webkitIDBKeyRange.lowerBound(3.12);
On 2010/12/09 17:40:19, jorlow wrote:
> Is 3.12 intentional?

Yes, but there's no deep rationale for it. Just figured we shouldn't always set
the bound to the exact value.

Expand Messages | Collapse Messages