Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/prerender/prerender_interceptor_unittest.cc

Issue 5695001: Disabling PrerenderInterceptorTests's due to memory leaks.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_interceptor.h" 5 #include "chrome/browser/prerender/prerender_interceptor.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 void PrerenderInterceptorTest::MakeTestUrl(const std::string& base) { 58 void PrerenderInterceptorTest::MakeTestUrl(const std::string& base) {
59 gurl_ = test_server_.GetURL(base); 59 gurl_ = test_server_.GetURL(base);
60 req_.reset(new TestURLRequest(gurl_, new TestDelegate())); 60 req_.reset(new TestURLRequest(gurl_, new TestDelegate()));
61 } 61 }
62 62
63 void PrerenderInterceptorTest::SetLastInterceptedGurl(const GURL& url) { 63 void PrerenderInterceptorTest::SetLastInterceptedGurl(const GURL& url) {
64 last_intercepted_gurl_ = url; 64 last_intercepted_gurl_ = url;
65 } 65 }
66 66
67 TEST_F(PrerenderInterceptorTest, Interception) { 67 // Temporarily disabling PrerenderInterceptorTest's due to a leak.
68 // I have a fix, but will land in the morning.
69 // http://crbug.com/65993
70 TEST_F(PrerenderInterceptorTest, DISABLED_Interception) {
68 MakeTestUrl("files/prerender/doc1.html"); 71 MakeTestUrl("files/prerender/doc1.html");
69 req_->set_load_flags(req_->load_flags() | net::LOAD_PREFETCH); 72 req_->set_load_flags(req_->load_flags() | net::LOAD_PREFETCH);
70 req_->Start(); 73 req_->Start();
71 74
72 MessageLoop::current()->Run(); 75 MessageLoop::current()->Run();
73 EXPECT_EQ(URLRequestStatus::SUCCESS, req_->status().status()); 76 EXPECT_EQ(URLRequestStatus::SUCCESS, req_->status().status());
74 EXPECT_EQ(gurl_, last_intercepted_gurl_); 77 EXPECT_EQ(gurl_, last_intercepted_gurl_);
75 } 78 }
76 79
77 TEST_F(PrerenderInterceptorTest, NotAPrefetch) { 80 TEST_F(PrerenderInterceptorTest, DISABLED_NotAPrefetch) {
78 MakeTestUrl("files/prerender/doc2.html"); 81 MakeTestUrl("files/prerender/doc2.html");
79 req_->set_load_flags(req_->load_flags() & ~net::LOAD_PREFETCH); 82 req_->set_load_flags(req_->load_flags() & ~net::LOAD_PREFETCH);
80 req_->Start(); 83 req_->Start();
81 84
82 MessageLoop::current()->Run(); 85 MessageLoop::current()->Run();
83 EXPECT_EQ(URLRequestStatus::SUCCESS, req_->status().status()); 86 EXPECT_EQ(URLRequestStatus::SUCCESS, req_->status().status());
84 EXPECT_NE(gurl_, last_intercepted_gurl_); 87 EXPECT_NE(gurl_, last_intercepted_gurl_);
85 } 88 }
86 89
87 TEST_F(PrerenderInterceptorTest, WrongMimeType) { 90 TEST_F(PrerenderInterceptorTest, DISABLED_WrongMimeType) {
88 MakeTestUrl("files/prerender/image.jpeg"); 91 MakeTestUrl("files/prerender/image.jpeg");
89 req_->set_load_flags(req_->load_flags() | net::LOAD_PREFETCH); 92 req_->set_load_flags(req_->load_flags() | net::LOAD_PREFETCH);
90 req_->Start(); 93 req_->Start();
91 94
92 MessageLoop::current()->Run(); 95 MessageLoop::current()->Run();
93 EXPECT_EQ(URLRequestStatus::SUCCESS, req_->status().status()); 96 EXPECT_EQ(URLRequestStatus::SUCCESS, req_->status().status());
94 EXPECT_NE(gurl_, last_intercepted_gurl_); 97 EXPECT_NE(gurl_, last_intercepted_gurl_);
95 } 98 }
96 99
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698