Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3104)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h

Issue 5694001: Rework how bookmark bar folder menus and submenus are layed out when scrollin... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h
===================================================================
--- chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h (revision 70424)
+++ chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h (working copy)
@@ -13,17 +13,16 @@
// Window for a bookmark folder "menu". This menu pops up when you
// click on a bookmark button that represents a folder of bookmarks.
-// This window is borderless.
+// This window is borderless but has a shadow, at least initially.
+// Once the down scroll arrow is shown, the shadow is turned off and
+// a secondary window is added which is sized to match the visible
+// area of the menu and which provides the shadow.
@interface BookmarkBarFolderWindow : NSWindow
@end
// Content view for the above window. "Stock" other than the drawing
// of rounded corners. Only used in the nib.
-@interface BookmarkBarFolderWindowContentView : NSView {
- // Arrows to show ability to scroll up and down as needed.
- scoped_nsobject<NSImage> arrowUpImage_;
- scoped_nsobject<NSImage> arrowDownImage_;
-}
+@interface BookmarkBarFolderWindowContentView : NSView
@end
// Scroll view that contains the main view (where the buttons go).

Powered by Google App Engine
This is Rietveld 408576698