Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 569035: Remove the HostResolver::Shutdown() method.... (Closed)

Created:
10 years, 10 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, darin (slow to review), ben+cc_chromium.org
Visibility:
Public.

Description

Remove the HostResolver::Shutdown() method. While this doesn't entirely remove the hack, it limits the scope of it to HostResolverImpl. Hopefully in the future HostResolver will not be refcounted so this can go away altogether. BUG=18373 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38243

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync and address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -17 lines) Patch
M chrome/browser/io_thread.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M net/base/fixed_host_resolver.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/base/host_resolver.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/base/host_resolver_impl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/mock_host_resolver.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/mock_host_resolver.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M net/socket/socks_client_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
Minor cleanup...
10 years, 10 months ago (2010-02-04 01:54:40 UTC) #1
willchan no longer on Chromium
lgtm, i just have some commenting nits http://codereview.chromium.org/569035/diff/1/7 File chrome/browser/io_thread.cc (right): http://codereview.chromium.org/569035/diff/1/7#newcode132 chrome/browser/io_thread.cc:132: // TODO(eroman): ...
10 years, 10 months ago (2010-02-04 21:42:04 UTC) #2
eroman
http://codereview.chromium.org/569035/diff/1/7 File chrome/browser/io_thread.cc (right): http://codereview.chromium.org/569035/diff/1/7#newcode132 chrome/browser/io_thread.cc:132: // TODO(eroman): hack http://crbug.com/18373 On 2010/02/04 21:42:04, willchan wrote: ...
10 years, 10 months ago (2010-02-05 05:07:12 UTC) #3
willchan no longer on Chromium
10 years, 10 months ago (2010-02-05 18:41:08 UTC) #4
in case you were waiting for my comment, it still lgtm

Powered by Google App Engine
This is Rietveld 408576698