Add ability to store the manifest in the manifest directory.

Add ability to store the manifest in the manifest directory.

Change-Id: I1ac3ed12df00424ba5ba2d1c61fd6fe9716e13b9

BUG=chromium-os:9714
TEST=Ran new unittests as well as ran cbuildbot on local b/cbuild

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c663f20

[sosa, 2010-12-10 23:43:20]

Yo scott can you take a look at this?

[scottz, 2010-12-11 00:01:53]

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot.py#newcode335
bin/cbuildbot.py:335: public_overlay = PUBLIC_OVERLAY % {'buildroot': buildroot}
since you use {'buildroot': buildroot] in so many places why not set it in a
variable? 

str_replace_dict = {'buildroot': buildroot} then put that everywhere.

Just a suggestion

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot.py#newcode360
bin/cbuildbot.py:360: shutil.copy(manifest_path, '/dev/stderr')
Why are we doing this?

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot_unittest.py
File bin/cbuildbot_unittest.py (right):

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot_unittest.py#n...
bin/cbuildbot_unittest.py:268: overlay = overlay_no_buildroot % { 'buildroot':
temp_root }
{'

[sosa, 2010-12-13 18:46:39]

PTAL, re-tested.

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot.py
File bin/cbuildbot.py (right):

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot.py#newcode335
bin/cbuildbot.py:335: public_overlay = PUBLIC_OVERLAY % {'buildroot': buildroot}
Rather not since buildroot would have to be defined before that was defined and
so i'd have to pass that around everywhere.

On 2010/12/11 00:01:53, scottz wrote:
> since you use {'buildroot': buildroot] in so many places why not set it in a
> variable? 
> 
> str_replace_dict = {'buildroot': buildroot} then put that everywhere.
> 
> Just a suggestion

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot.py#newcode360
bin/cbuildbot.py:360: shutil.copy(manifest_path, '/dev/stderr')
On 2010/12/11 00:01:53, scottz wrote:
> Why are we doing this?

Moved out to a function that does standard open, read, close

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot_unittest.py
File bin/cbuildbot_unittest.py (right):

http://codereview.chromium.org/5689003/diff/11001/bin/cbuildbot_unittest.py#n...
bin/cbuildbot_unittest.py:268: overlay = overlay_no_buildroot % { 'buildroot':
temp_root }
On 2010/12/11 00:01:53, scottz wrote:
> {'

Done.

[scottz, 2010-12-13 19:10:55]

LGTM