src/x64/codegen-x64.cc - Issue 5686006: Add array bound checks to code generated for SwapElements. This fixes a bug t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 5686006: Add array bound checks to code generated for SwapElements. This fixes a bug t... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/codegen-x64.cc

===================================================================

--- src/x64/codegen-x64.cc (revision 6016)

+++ src/x64/codegen-x64.cc (working copy)

@@ -6782,6 +6782,13 @@

Condition both_smi = masm()->CheckBothSmi(index1.reg(), index2.reg());

deferred->Branch(NegateCondition(both_smi));

+ // Check that both indices are valid.

+ __ movq(tmp2.reg(), FieldOperand(object.reg(), JSArray::kLengthOffset));

+ __ cmpl(tmp2.reg(), index1.reg());

+ deferred->Branch(below_equal);

+ __ cmpl(tmp2.reg(), index2.reg());

+ deferred->Branch(below_equal);

// Bring addresses into index1 and index2.

__ SmiToInteger32(index1.reg(), index1.reg());

__ lea(index1.reg(), FieldOperand(tmp1.reg(),

« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | test/mjsunit/regress/regress-swapelements.js » ('j') | no next file with comments »